Port missmatch fix#522
Closed
alexander-poulikakos wants to merge 7 commits intoappium:masterfrom
alexander-poulikakos:port_missmatch_fix
Closed
Port missmatch fix#522alexander-poulikakos wants to merge 7 commits intoappium:masterfrom alexander-poulikakos:port_missmatch_fix
alexander-poulikakos wants to merge 7 commits intoappium:masterfrom
alexander-poulikakos:port_missmatch_fix
Conversation
|
|
Contributor
Author
|
I'll take a look at the travis errors. Just signed the CLA. |
Contributor
Author
|
Travis errors fixed. |
TikhomirovSergey
added a commit
that referenced
this pull request
Nov 25, 2016
* Make AppiumService aware of port number when using withArgument(...) method. * Use equalsIgnoreCase instead * changed to toLowerCase instead. * switched order of equals check. * code formating fixes. * Code formating fixes * Changed unit test names * The addition to #522 - the ability use ip and log file as server args was provided - test update/fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request as discussed in issue #521